Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where images do not show up in IOS correctly on release #443

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

keli13
Copy link
Contributor

@keli13 keli13 commented Jan 29, 2021

Description of change

Added image as an ios asset resource to fix RN issue with loading images on IOS

Original issue(s)

department-of-veterans-affairs/va.gov-team#16448

Screenshots

Before:
Screen Shot 2021-01-29 at 11 24 39 AM

After:
Screen Shot 2021-01-29 at 11 25 41 AM

Testing Considerations

Updated tests

Reviewers

DF:
@jmarchi
@keli13
@komaly15
@DF-ClaytonMatulich

Ad Hoc:
@lexicalninja (Patrick S)

@keli13 keli13 merged commit d4e4ac9 into develop Jan 29, 2021
@keli13 keli13 deleted the ios_images branch January 29, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image cannot show image in iOS 14
4 participants