feat(rstcheck): Add automatic --config support with version check#5095
Merged
w0rp merged 2 commits intodense-analysis:masterfrom Feb 11, 2026
Merged
feat(rstcheck): Add automatic --config support with version check#5095w0rp merged 2 commits intodense-analysis:masterfrom
w0rp merged 2 commits intodense-analysis:masterfrom
Conversation
Member
|
Just needs some tests adding. I'll ask OpenCode to give it a go. |
w0rp
approved these changes
Feb 11, 2026
Member
w0rp
left a comment
There was a problem hiding this comment.
GPT 5.3 Codex in OpenCode one-shotted the tests with some instructions I'll add. I do recommend.
Cheers! 🍻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements automatic support for the
--configoption inrstcheckwhen the installed version supports it (>= 3.4.0).This solves the issue where
rstcheckwould not load project-level configuration files (e.g.,.rstcheck.cfg) because ALE runs linters on temporary files in/tmp. By passing--config <file_dir>, we ensurerstchecklooks for configuration in the correct location.Implementation Details
ale#semver#RunWithVersionCheckto detectrstcheckversion.>= 3.4.0, automatically appends--configwith the file's directory.Handlefunction from PR Call rstcheck with --config option #2411 to correctly parserstcheckoutput format.g:ale_rst_rstcheck_use_project_config) as requested in previous reviews.References
Question for Reviewers
Is this implementation aligned with what you expected ?
If the approach looks good to you, I will proceed with adding the Vader tests.