Skip to content

Comments

feat(rstcheck): Add automatic --config support with version check#5095

Merged
w0rp merged 2 commits intodense-analysis:masterfrom
PsickOSSH:rstcheck-add-config-support
Feb 11, 2026
Merged

feat(rstcheck): Add automatic --config support with version check#5095
w0rp merged 2 commits intodense-analysis:masterfrom
PsickOSSH:rstcheck-add-config-support

Conversation

@PsickOSSH
Copy link
Contributor

Description

This PR implements automatic support for the --config option in rstcheck when the installed version supports it (>= 3.4.0).

This solves the issue where rstcheck would not load project-level configuration files (e.g., .rstcheck.cfg) because ALE runs linters on temporary files in /tmp. By passing --config <file_dir>, we ensure rstcheck looks for configuration in the correct location.

Implementation Details

  • Used ale#semver#RunWithVersionCheck to detect rstcheck version.
  • If version is >= 3.4.0, automatically appends --config with the file's directory.
  • Re-integrated the custom Handle function from PR Call rstcheck with --config option #2411 to correctly parse rstcheck output format.
  • Removed the need for manual configuration options (like g:ale_rst_rstcheck_use_project_config) as requested in previous reviews.

References

Question for Reviewers

Is this implementation aligned with what you expected ?
If the approach looks good to you, I will proceed with adding the Vader tests.

@w0rp
Copy link
Member

w0rp commented Feb 11, 2026

Just needs some tests adding. I'll ask OpenCode to give it a go.

Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.3 Codex in OpenCode one-shotted the tests with some instructions I'll add. I do recommend.

Cheers! 🍻

@w0rp w0rp enabled auto-merge (squash) February 11, 2026 21:10
@w0rp w0rp merged commit 3c83771 into dense-analysis:master Feb 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rstcheck cannot use config files Implement ale_rst_rstcheck_options

2 participants