Skip to content

Conversation

pmonson711
Copy link

@pmonson711 pmonson711 commented Aug 29, 2025

Hopefully this should cover #5035.

I wasn't sure if/how I should cover the call to ale#path#FindNearestExecutable with tests, I'm happy to find examples and add them if wanted/needed.

@pmonson711 pmonson711 marked this pull request as ready for review August 29, 2025 15:17
Copy link
Contributor

@rymdbar rymdbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me! Please rethink improved platform support and correct a few trivial typos and such.

@pmonson711 pmonson711 requested a review from rymdbar September 2, 2025 15:15
Your Name added 3 commits September 11, 2025 08:23
- Simplify configuration by removing executable lookup logic
- Update documentation to reflect current configuration options
- Rename test file and update assertions for the new configuration
The install instructions included something I missed. It includes a
global install, where the default executable is just `expert`. I'll
default to that and review if I should should add a configuration for a
global config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants