refactor(node): move throw error out of finally block to pass no-unsafe-finally#810
Merged
ry merged 1 commit intodenoland:mainfrom Mar 21, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code should violate
no-unsafe-finally, but due to a bug of deno_lint, no lint error happens at the moment.(This bug is fixed in denoland/deno_lint#641)
In fact, if we run ESLint with
no-unsafe-finallyenabled, the following output is emitted:It looks like this
if (error) throw error;could be moved out of the finally block. This patch did so to work aroundno-unsafe-finally.