feat(crypto/unstable): add AES-GCM encrypt/decrypt helpers#7012
Open
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Open
feat(crypto/unstable): add AES-GCM encrypt/decrypt helpers#7012tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7012 +/- ##
=======================================
Coverage 94.16% 94.17%
=======================================
Files 618 619 +1
Lines 48802 48849 +47
Branches 8601 8609 +8
=======================================
+ Hits 45954 46003 +49
+ Misses 2779 2777 -2
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High-level wrappers around Web Crypto's AES-GCM that generate a random 96-bit nonce and produce wire format (
nonce (12 bytes) || ciphertext || tag (16 bytes)). Inspired by Golang's NewGCMWithRandomNonce.AES-GCM is the only AEAD cipher in the Web Crypto spec, using it correctly requires the caller to: generate a 12-byte random nonce, call
crypto.subtle.encrypt, concatenate nonce + ciphertext + tag, and reverse the process on decrypt with length validation. These two helpers solve this common use case.Future streaming complement: WICG proposal #185