Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toml): make toml parse() generic #6483

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (96116ce) to head (718a0fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6483      +/-   ##
==========================================
- Coverage   95.50%   95.50%   -0.01%     
==========================================
  Files         575      575              
  Lines       43279    43281       +2     
  Branches     6472     6472              
==========================================
  Hits        41335    41335              
- Misses       1905     1907       +2     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Mar 18, 2025

I'm not in favor of this change as other similar parsers (yaml, jsonc, etc) are not generic. Also this doesn't seem making typing more correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants