deprecation(semver): deprecate eq(), neq(), lt(), lte(), gt() and gte()
#4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
suggested changes
Jan 2, 2024
Comment on lines
+58
to
+101
| // taken over from `eq_test.ts` | ||
| Deno.test({ | ||
| name: "compare()", | ||
| fn: async (t) => { | ||
| // [version1, version2] | ||
| // version1 should be greater than version2 | ||
| const versions: [string, string, number][] = [ | ||
| ["0.0.0", "0.0.0", 0], | ||
| ["1.2.3", "1.2.3", 0], | ||
| ["1.2.3-pre.0", "1.2.3-pre.0", 0], | ||
| ["1.2.3-pre.0+abc", "1.2.3-pre.0+abc", 0], | ||
| ["0.0.0", "0.0.0-foo", 1], | ||
| ["0.0.1", "0.0.0", 1], | ||
| ["1.0.0", "0.9.9", 1], | ||
| ["0.10.0", "0.9.0", 1], | ||
| ["0.99.0", "0.10.0", 1], | ||
| ["2.0.0", "1.2.3", 1], | ||
| ["1.2.3", "1.2.3-asdf", 1], | ||
| ["1.2.3", "1.2.3-4", 1], | ||
| ["1.2.3", "1.2.3-4-foo", 1], | ||
| ["1.2.3-5", "1.2.3-5-foo", -1], // numbers > strings, `5-foo` is a string not a number | ||
| ["1.2.3-5", "1.2.3-4", 1], | ||
| ["1.2.3-5-foo", "1.2.3-5-Foo", 1], | ||
| ["3.0.0", "2.7.2+asdf", 1], | ||
| ["1.2.3-a.10", "1.2.3-a.5", 1], | ||
| ["1.2.3-a.5", "1.2.3-a.b", -1], | ||
| ["1.2.3-a.b", "1.2.3-a", 1], | ||
| ["1.2.3-a.b.c.10.d.5", "1.2.3-a.b.c.5.d.100", 1], | ||
| ["1.2.3-r2", "1.2.3-r100", 1], | ||
| ["1.2.3-r100", "1.2.3-R2", 1], | ||
| ]; | ||
|
|
||
| for (const [v0, v1, expected] of versions) { | ||
| await t.step(`${v0} == ${v1}`, () => { | ||
| const s0 = parse(v0); | ||
| const s1 = parse(v1); | ||
|
|
||
| const eq = compare(s0, s1); | ||
| const op = expected ? "==" : "!="; | ||
| assertEquals(eq, expected, `${s0} ${op} ${s1}`); | ||
| }); | ||
| } | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This is the only test needed. It takes care of all of the other equality and inequality cases more precisely.
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
|
I'd prefer to keep these methods as they are easier to remember than the meaning of return values of |
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Ok, I will close this in favour of another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #3948 (comment)
eq(),neq(),lt(),lte(),gt()andgte()compare()jsdoc