Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use windows-xl runners, too expensive #3021

Merged
merged 2 commits into from
Dec 20, 2022
Merged

fix: don't use windows-xl runners, too expensive #3021

merged 2 commits into from
Dec 20, 2022

Conversation

ry
Copy link
Member

@ry ry commented Dec 19, 2022

No description provided.

@lino-levan
Copy link
Contributor

LGTM

@iuioiua
Copy link
Contributor

iuioiua commented Dec 19, 2022

Should the same be done with the ubuntu-20.04-xl runner?

@lino-levan
Copy link
Contributor

lino-levan commented Dec 19, 2022

@iuioiua pricing for runners varies immensely depending on the OS, linux in general is the cheapest option so this is probably reasonably limited to windows-xl

ref: https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#per-minute-rates

@iuioiua
Copy link
Contributor

iuioiua commented Dec 19, 2022

True. However, seeing as nothing particularly intensive is going on in the repo, ubuntu-20.04-xl may not be needed.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The execution time is still not that bad (4m & 6m)

@ry ry merged commit 0c0f6d5 into main Dec 20, 2022
@ry ry deleted the windows-xl branch December 20, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants