feat: add createAssertSnapshot #2403
Conversation
kt3k
left a comment
kt3k
left a comment
There was a problem hiding this comment.
@bcheidemann Thanks for the PR. The API design and testing look good to me. Nice work!
Can you also add docs in testing/README.md?
testing/asserts.ts
Outdated
|
|
||
| /** Executes a function which returns a promise, expecting it to reject. */ | ||
| export function assertRejects( | ||
| export function assertRejects<T = unknown>( |
There was a problem hiding this comment.
Seems like an unrelated change, what's the reason for it?
There was a problem hiding this comment.
Ah, probably it's better to keep this unknown as the thrown value is not type checked
There was a problem hiding this comment.
Thanks for flagging, I will remove this change and refactor the test to use the format outlined below
testing/snapshot_test.ts
Outdated
| name: "[MISSING SNAPSHOT]", | ||
| }); | ||
|
|
||
| const err = await assertRejects<AssertionError>(async () => { |
There was a problem hiding this comment.
Let's use assertRejects(fn, AssertionError) call, that will give correct type to err
Yeah no problem :) |
| snapshot files. As such, the allow list for `--allow-read` and `--allow-write` | ||
| can be limited to only include existing snapshot files, if so desired. | ||
|
|
||
| ### Options: |
3 participants
Closes #2214