feat(node/_error): Implement ERR_INVALID_URL_SCHEME
#1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wafuwafu13
commented
Oct 6, 2021
| @@ -2395,3 +2394,16 @@ export class ERR_INVALID_URL extends NodeTypeError { | |||
| this.input = input; | |||
| } | |||
| } | |||
|
|
|||
| export class ERR_INVALID_URL_SCHEME extends NodeTypeError { | |||
There was a problem hiding this comment.
wafuwafu13
commented
Oct 6, 2021
| @@ -10,8 +10,6 @@ Deno.test({ | |||
| }, | |||
| }); | |||
|
|
|||
| // todo(wafuwafu13) Add Windows and invalid case | |||
There was a problem hiding this comment.
Related: #1335 (review)
|
I don't know why |
|
This will be fixed once denoland/deno#12348 lands |
kt3k
approved these changes
Oct 7, 2021
| @@ -6,8 +6,7 @@ | |||
| ], | |||
| "parallel": [ | |||
| "test-assert-async.js", | |||
| "test-assert.js", | |||
| "test-url-fileurltopath.js" | |||
traceypooh
pushed a commit
to traceypooh/deno_std
that referenced
this pull request
Nov 14, 2021
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #911
ERR_INVALID_URL_SCHEMEERR_INVALID_URL_SCHEMEconfig.json