Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Object::get_property_names() and Object::get_own_property_names() #1049

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Improve Object::get_property_names() and Object::get_own_property_names() #1049

merged 3 commits into from
Sep 3, 2022

Conversation

RaisinTen
Copy link
Contributor

This change allows the customization of the behavior of
v8::Object::GetOwnPropertyNames() and v8::Object::GetPropertyNames() by
accepting all the options that the raw V8 API supports.

Fixes: #740
Signed-off-by: Darshan Sen raisinten@gmail.com

cc @bnoordhuis

@RaisinTen RaisinTen mentioned this pull request Aug 15, 2022
Closed
RaisinTen
RaisinTen commented Aug 15, 2022
View reviewed changes
tests/test_api.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

tests/test_api.rs Outdated Show resolved Hide resolved
@RaisinTen RaisinTen marked this pull request as draft August 20, 2022 10:50
@RaisinTen RaisinTen force-pushed the improve-get_property_names branch 2 times, most recently from 1f90275 to c9bb339 Compare August 21, 2022 11:48
@RaisinTen
Improve Object::get_property_names() and Object::get_own_property_nam…
ecc023e 
…es()

This change allows the customization of the behavior of
v8::Object::GetOwnPropertyNames() and v8::Object::GetPropertyNames() by
accepting all the options that the raw V8 API supports.

Fixes: denoland#740
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen marked this pull request as ready for review August 21, 2022 11:49
bartlomieju
bartlomieju reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @RaisinTen, thank you. I have just one small nitpick

tests/test_api.rs Outdated Show resolved Hide resolved
@RaisinTen
Implement Default for GetPropertyNamesArgsBuilder
23d4b04 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen
fixup! Implement Default for GetPropertyNamesArgsBuilder
590bdbb 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
bartlomieju
bartlomieju approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @RaisinTen, it's a great improvement!

@RaisinTen
Copy link
Contributor Author

Since this changes the API of get_own_property_names() which is used in a couple of places in the core repo, I'd be up for handling the rusty_v8 upgrade in deno. Letting you know in advance since I've noticed that you have done most of the recent rusty_v8 upgrades in deno. I can send a PR tomorrow morning India time if you're good with that. :)

@bartlomieju
Copy link
Member

Since this changes the API of get_own_property_names() which is used in a couple of places in the core repo, I'd be up for handling the rusty_v8 upgrade in deno. Letting you know in advance since I've noticed that you have done most of the recent rusty_v8 upgrades in deno. I can send a PR tomorrow morning India time if you're good with that. :)

Sounds good, but keep in mind that it might take a couple more weeks before we release a new version of rusty_v8. Feel free to open a PR with override in core/Cargo.toml pointing to local version of rusty_v8

@bartlomieju bartlomieju merged commit dbf19c8 into denoland:main Sep 3, 2022
@RaisinTen RaisinTen deleted the improve-get_property_names branch September 4, 2022 05:22
@RaisinTen
Copy link
Contributor Author

👍 opened the upgrade PR as a draft - denoland/deno#15762

@RaisinTen RaisinTen mentioned this pull request Sep 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Object::get_own_property_names()
2 participants
@RaisinTen @bartlomieju