Skip to content

Commit e88ea4a

Browse files
committed
Downgrade to V8 8.6.334 again (#447)
After the upgrade some Deno tests started crashing somewhere deep inside V8, and the cause of these crashes is unclear. This reverts the following commits: * 12334ff Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443) * f53f10d Upgrade V8 to 8.7.25 (#443)
1 parent 7b62f73 commit e88ea4a

File tree

13 files changed

+23
-21
lines changed

13 files changed

+23
-21
lines changed

BUILD.gn

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
11
# Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
2+
import("//v8/gni/v8.gni")
23

3-
static_library("rusty_v8") {
4-
complete_static_lib = true
4+
v8_static_library("rusty_v8") {
55
sources = [ "src/binding.cc" ]
66
deps = [
7+
":v8",
78
"//build/config:shared_library_deps",
9+
]
10+
configs = [ ":rusty_v8_config" ]
11+
}
12+
13+
v8_source_set("v8") {
14+
deps = [
815
"//v8:v8",
916
"//v8:v8_libbase",
1017
"//v8:v8_libplatform",
1118
"//v8:v8_libsampler",
1219
]
13-
configs -= [
14-
"//build/config/compiler:default_init_stack_vars",
15-
"//build/config/compiler:thin_archive",
16-
]
17-
configs += [ ":rusty_v8_config" ]
20+
configs = [ ":rusty_v8_config" ]
1821
}
1922

2023
config("rusty_v8_config") {

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Rusty V8 Binding
22

3-
V8 Version: 8.7.25
3+
V8 Version: 8.6.334
44

55
[![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=master)](https://github.com/denoland/rusty_v8/actions)
66
[![crates](https://img.shields.io/crates/v/rusty_v8.svg)](https://crates.io/crates/rusty_v8)

build

Submodule build updated 115 files

build.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ fn download_ninja_gn_binaries() {
149149
.parent()
150150
.unwrap();
151151
let bin_dir = target_dir
152-
.join("ninja_gn_binaries-20200827")
152+
.join("ninja_gn_binaries-20200806")
153153
.join(platform());
154154
let gn = bin_dir.join("gn");
155155
let ninja = bin_dir.join("ninja");

buildtools

Submodule buildtools updated 1 file

tests/test_api.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3402,8 +3402,7 @@ fn heap_statistics() {
34023402
assert!(s.total_global_handles_size() >= s.used_global_handles_size());
34033403
assert!(s.used_heap_size() > 0);
34043404
assert!(s.heap_size_limit() >= s.used_heap_size());
3405-
assert!(s.peak_malloced_memory() > 0);
3406-
assert!(s.malloced_memory() > 0);
3405+
assert!(s.peak_malloced_memory() >= s.malloced_memory());
34073406
assert_eq!(s.number_of_native_contexts(), 0);
34083407

34093408
let scope = &mut v8::HandleScope::new(isolate);

third_party/jinja2

Submodule jinja2 updated from 61cfe2a to 3f90fa0

third_party/markupsafe

Submodule markupsafe updated from f2fb0f2 to 8f45f5c

third_party/zlib

Submodule zlib updated from d53accf to 7492de9

tools/clang

Submodule clang updated from 708cbfd to 8a232eb

0 commit comments

Comments
 (0)