Skip to content

Upgrade V8 to 8.7.25 #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 27, 2020
Merged

Upgrade V8 to 8.7.25 #443

merged 8 commits into from
Aug 27, 2020

Conversation

@ry
Copy link
Member

@ry ry commented Aug 26, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ry
ry commented Aug 26, 2020
View reviewed changes
@piscisaureus piscisaureus force-pushed the v8-8.7.25 branch 3 times, most recently from 33ff94e to d460aa2 Compare August 27, 2020 02:01
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Format source code and fix clippy lint (#443)
6db3df9
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade Rust crates (#443)
e16d211
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443)
79aef18
piscisaureus pushed a commit that referenced this pull request Aug 27, 2020
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
e86fcbb
@piscisaureus piscisaureus changed the title upgrade v8 to 8.7.25 Upgrade V8 to 8.7.25 Aug 27, 2020
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Format source code and fix clippy lint (#443)
ce913b9
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade Rust crates (#443)
515677a
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443)
3c8d2d4
piscisaureus pushed a commit that referenced this pull request Aug 27, 2020
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
08af9eb
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Format source code and fix clippy lint (#443)
e68d98f
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade Rust crates (#443)
6c8e184
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443)
01dcf61
piscisaureus pushed a commit that referenced this pull request Aug 27, 2020
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
7a623ab
@piscisaureus piscisaureus force-pushed the v8-8.7.25 branch 3 times, most recently from cbcdbf6 to 32c2538 Compare August 27, 2020 18:15
piscisaureus pushed a commit that referenced this pull request Aug 27, 2020
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
b2302ac
@piscisaureus piscisaureus force-pushed the v8-8.7.25 branch 3 times, most recently from 4b57607 to b2302ac Compare August 27, 2020 18:36
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
ci: don't store $CARGO_HOME in Github Actions cache (#443)
8e35aaf 
There currently is a problem related to Github Actions in general or the
'actions-rs/cargo' action in particular, which causes cargo to be unable
to find the 'serde_derive' crate when the cargo home dir has been
restored from cache.

This issue is also being reported by others, e.g. at
actions-rs/cargo#111.
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
ci: always save Github Actions cache after V8 upgrade (#443)
f2a2ac7
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade Rust crates (#443)
da6b062
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443)
23bd4d6
piscisaureus pushed a commit that referenced this pull request Aug 27, 2020
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
286a35b
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
ci: upgrade to Rust 1.46.0 (#443)
a595ae9
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
ci: don't store $CARGO_HOME in Github Actions cache (#443)
fbca767 
There currently is a problem related to Github Actions in general or the
'actions-rs/cargo' action in particular, which causes cargo to be unable
to find the 'serde_derive' crate when the cargo home dir has been
restored from cache.

This issue is also being reported by others, e.g. at
actions-rs/cargo#111.
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
ci: always save Github Actions cache after V8 upgrade (#443)
3a225be
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade Rust crates (#443)
8d62280
piscisaureus added a commit that referenced this pull request Aug 27, 2020
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443)
8f646b1
piscisaureus pushed a commit that referenced this pull request Aug 27, 2020
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
ae8748a
piscisaureus and others added 6 commits August 27, 2020 23:38
@piscisaureus
ci: upgrade to Rust 1.46.0 (#443)
fdc0323
@piscisaureus
ci: don't store $CARGO_HOME in Github Actions cache (#443)
ac9bb44 
There currently is a problem related to Github Actions in general or the
'actions-rs/cargo' action in particular, which causes cargo to be unable
to find the 'serde_derive' crate when the cargo home dir has been
restored from cache.

This issue is also being reported by others, e.g. at
actions-rs/cargo#111.
@piscisaureus
ci: always save Github Actions cache after V8 upgrade (#443)
c1804c2
@piscisaureus
Upgrade Rust crates (#443)
492d6b3
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (#443)
12334ff
@ry @piscisaureus
Upgrade V8 to 8.7.25 (#443)
f53f10d
@piscisaureus piscisaureus self-requested a review August 27, 2020 22:28
@piscisaureus piscisaureus merged commit f53f10d into master Aug 27, 2020
@piscisaureus piscisaureus deleted the v8-8.7.25 branch August 27, 2020 22:28
piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Aug 28, 2020
@piscisaureus
Downgrade to V8 8.6.334 again (denoland#447)
3528dcd 
After the upgrade some Deno tests started crashing somewhere deep inside
V8, and the cause of these crashes is unclear.

This reverts the following commits:
* 12334ff Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (denoland#443)
* f53f10d Upgrade V8 to 8.7.25 (denoland#443)
piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Aug 28, 2020
@piscisaureus
Downgrade to V8 8.6.334 again (denoland#447)
e88ea4a 
After the upgrade some Deno tests started crashing somewhere deep inside
V8, and the cause of these crashes is unclear.

This reverts the following commits:
* 12334ff Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (denoland#443)
* f53f10d Upgrade V8 to 8.7.25 (denoland#443)
piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Sep 7, 2020
@piscisaureus
Upgrade gn to 6f13aaac; make BUILD.gn compatible with it (denoland#443)
7c746c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ry @CLAassistant @piscisaureus