Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the delimiter associated with the parser options #41

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Improve the delimiter associated with the parser options #41

merged 2 commits into from
Jul 26, 2024

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Feb 4, 2023

Hi,

This PR changes the type of the delimiter associated with the parser options and resolves the following TODO:

rust-urlpattern/src/parser.rs

Line 27 in e65cfc9

pub delimiter_code_point: String, // TODO: It must contain one ASCII code point or the empty string. maybe Option<char>?

crowlKats
crowlKats approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@crowlKats crowlKats merged commit 6b09f74 into denoland:main Jul 26, 2024
2 checks passed
@woxtu woxtu deleted the delimiter-char branch August 2, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @crowlKats