Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed values in format strings #38

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jan 28, 2023

Hi,

This PR changes to embed values in format strings to fix clippy warnings.

Ref: https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@crowlKats crowlKats merged commit b792513 into denoland:main Jan 28, 2023
@woxtu woxtu deleted the format-string branch January 29, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants