Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $fresh ref in import sources #2340

Merged
merged 14 commits into from
Mar 12, 2024

Conversation

mcgear
Copy link
Contributor

@mcgear mcgear commented Feb 26, 2024

There was an issue with the tailwind error page being pulled in by ref to $fresh, fixed so now it just uses the file

Copy link
Contributor

@deer deer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you didn't base this off main, but rather your build mode branch.

@mcgear
Copy link
Contributor Author

mcgear commented Feb 27, 2024

Ahh, right. Yea, i forgot to branch for my build mode changes. I removed those from this branch, so it is just the ref fixes.

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for making a PR 👍

@marvinhagemeister marvinhagemeister changed the title Fix fresh ref fix: $fresh ref in import sources Mar 12, 2024
@marvinhagemeister marvinhagemeister merged commit 671751d into denoland:main Mar 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants