fix: Prevent deserialize break on safari < 15.4 #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorbrasileiro
changed the title
igorbrasileiro
changed the title
This was referenced Jul 19, 2023
src/runtime/deserializer.ts
Outdated
| @@ -56,7 +56,7 @@ export function deserialize( | |||
| (o, k) => k === null ? o : o[k], | |||
| v, | |||
| ); | |||
| parent[refPath.at(-1)!] = target; | |||
| parent[refPath.slice(-1)[0]!] = target; | |||
There was a problem hiding this comment.
Cloning the array just to get the last value seems a bit much. Let's skip the temporary array allocation here by accessing the last item directly.
Suggested change
| parent[refPath.slice(-1)[0]!] = target; | |
| parent[refPath[refParent.length - 1]!] = target; |
There was a problem hiding this comment.
Oh, sure! Thank you =D
Signed-off-by: igorbrasileiro <brasileiro456@gmail.com>
marvinhagemeister
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The
. So, the hydration breaks in older browsers.
Array.prototype.atis only available at safari >= 15.4 caniusePreview: https://deco-sites-fashion-nfcj5n1zeycg.deno.dev/
The solution
This PR changes the
.at(-1)to[array.length - 1].