fix null versionstamp #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losfair
reviewed
Jul 29, 2024
| ? emptyVersionstamp | ||
| /* in proto3 all fields are optional, but the generated types don't | ||
| * like it, so we have to cast it manually */ | ||
| ? undefined as unknown as Uint8Array |
There was a problem hiding this comment.
I think you can just use new Uint8Array() here - the zero value is not distinguishable from an unset value in protobuf.
There was a problem hiding this comment.
While it will work, it will be encoded and take up some bandwidth (I actually measure it output). undefined is only way to make it same as deno version
losfair
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #85
use undefined is fine here, the generated type is wrong (the encodeBinary function actually compare the value with undefined)