Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use current deno executable even when not named deno #123

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix: use current deno executable even when not named deno #123

merged 3 commits into from
Oct 3, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 3, 2024 •
edited
Loading

lucacasonato
lucacasonato reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@dsherret
Copy link
Member Author

dsherret commented Oct 3, 2024

@lucacasonato not practically in this scenario. Let me know if you have any ideas.

@dsherret
Copy link
Member Author

dsherret commented Oct 3, 2024

Oh, actually I forgot this is unit testable.

@dsherret dsherret merged commit b62114c into denoland:main Oct 3, 2024
4 checks passed
@dsherret dsherret deleted the fix_deno_exec_not_named_deno branch October 3, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @lucacasonato @bartlomieju