Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(no-unsafe-negation): add doc & hint, switch to macro in test, etc. #654

Merged
merged 3 commits into from
Apr 4, 2021
Merged

refactor(no-unsafe-negation): add doc & hint, switch to macro in test, etc. #654

merged 3 commits into from
Apr 4, 2021

Conversation

magurotuna
Copy link
Member

@magurotuna magurotuna commented Apr 4, 2021 •
edited
Loading

This PR does:

  • add doc
  • add hint
  • switch to assert_lint_err! in test
  • use dprint_swc_ecma_ast_view

#159
#431
#330

This was referenced Apr 4, 2021
Open
Closed
bartlomieju
bartlomieju approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @magurotuna

@bartlomieju bartlomieju merged commit de2f60c into denoland:main Apr 4, 2021
@magurotuna magurotuna deleted the macro/no-unsafe-negation branch April 4, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magurotuna @bartlomieju