Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(no-setter-return): refine with ast-view and add sufficient tests #632

Merged
merged 6 commits into from
Mar 29, 2021
Merged

refactor(no-setter-return): refine with ast-view and add sufficient tests #632

merged 6 commits into from
Mar 29, 2021

Conversation

magurotuna
Copy link
Member

Part of #330, #431

This PR does:

  • rewrite with dprint_swc_ecma_ast_view
  • refine the implementation to avoid false negatives
  • add lots of tests (most come from ESLint)

This was referenced Mar 8, 2021
Open
Closed
@magurotuna
Copy link
Member Author

magurotuna commented Mar 8, 2021 •
edited
Loading

@lucacasonato do you have any idea about this error? https://github.com/denoland/deno_lint/pull/632/checks?check_run_id=2058739263

UPDATE: never mind, it seemed a temporary error.

@magurotuna magurotuna mentioned this pull request Mar 13, 2021
Merged
@bartlomieju bartlomieju merged commit 498d518 into denoland:main Mar 29, 2021
@magurotuna magurotuna deleted the no-setter-return branch March 31, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magurotuna @bartlomieju