Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(no-self-assign): switch to asset_lint_err! macro #605

Merged
merged 3 commits into from
Feb 5, 2021
Merged

refactor(no-self-assign): switch to asset_lint_err! macro #605

merged 3 commits into from
Feb 5, 2021

Conversation

magurotuna
Copy link
Member

Part of #431 and #330

  • switches to assert_lint_err!
  • adds hint
  • uses VisitAll to handle nested assignments properly

This was referenced Jan 31, 2021
Open
Closed
bartlomieju
bartlomieju approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 64232f8 into denoland:master Feb 5, 2021
@magurotuna magurotuna deleted the macro/no-self-assign branch February 5, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magurotuna @bartlomieju