Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-func-assign): handle FnExpr and nested assignments #540

Merged
merged 5 commits into from
Nov 16, 2020
Merged

fix(no-func-assign): handle FnExpr and nested assignments #540

merged 5 commits into from
Nov 16, 2020

Conversation

magurotuna
Copy link
Member

Part of #431, #330

What's done in this PR:

  • fix scope analyzer to handle FnExpr properly
  • handle nested assignments using VisitAll trait
  • switch to assert_lint_err! macro
  • port tests from ESLint

This was referenced Nov 16, 2020
Open
Closed
bartlomieju
bartlomieju approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit d8005a7 into denoland:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magurotuna @bartlomieju