fix(no-dupe-keys): handle nested objects & getter and setter with the same name #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
changed the title
|
@bartlomieju ready for review. PTAL |
magurotuna
changed the title
40 tasks
bartlomieju
approved these changes
Oct 18, 2020
Comment on lines
+283
to
+286
| // TODO(magurotuna): this leads to panic due to swc error | ||
| // It seems like tsc v4.0.2 cannot handle this either | ||
| // playground: https://www.typescriptlang.org/play?target=99&ts=4.0.2#code/MYewdgzgLgBCBGArGBeGBvAUDGBGMAXDACwBMANJgL4DcQA | ||
| // assert_lint_err::<NoDupeKeys>(r#"var x = { 1n: 1, 1: 2 };"#, 8); |
There was a problem hiding this comment.
@magurotuna could you report that in SWC repo?
There was a problem hiding this comment.
@bartlomieju I thought I would do so, but as I commented, the TypeScript compiler can't parse this either. So I felt like it's okay for now. But I'll report it anyway 😄
There was a problem hiding this comment.
Filed an issue about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #330
What I did In this PR:
const obj = { a: { b: 1, b: 2 } };const obj = { get a() {}, set a() {} };