Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-cond-assign): handle nested stuff #389

Merged
merged 3 commits into from
Oct 13, 2020
Merged

fix(no-cond-assign): handle nested stuff #389

merged 3 commits into from
Oct 13, 2020

Conversation

magurotuna
Copy link
Member

This is a part of #330

Allows no-cond-assign to be able to handle nested if, while, do-while, for, and conditional operators.

@magurotuna magurotuna mentioned this pull request Oct 13, 2020
Open
40 tasks
bartlomieju
bartlomieju approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @magurotuna

@bartlomieju bartlomieju merged commit d589728 into denoland:master Oct 13, 2020
@magurotuna magurotuna deleted the fix-no-cond-assign branch October 15, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magurotuna @bartlomieju