fix(fast_check): correctly handle rest parameters #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously rest parameters had an optional type annotation added to them when generated for overload positions. This is wrong. Additionally rest parameters in overloaded constructors were not handled correctly at all.
marvinhagemeister
approved these changes
Apr 12, 2024
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously rest parameters had an optional type annotation added to them when generated for overload positions. This is wrong.
Additionally rest parameters in overloaded constructors were not handled correctly at all.
Fixes a bug introduced in #432
And properly fixes jsr-io/jsr#376
I ran the output in the test case thru TSC, and it is happy with it now.