Skip to content

Commit

Permalink
ci: use ubuntu-24.04 (#933)
Browse files Browse the repository at this point in the history
Something strange has happened in the past two days - even though
we use `ubuntu-latest` image, suddenly runners started using
`ubuntu-22.04` instead of `ubuntu-24.04` that was used before.
Using explicit `ubuntu-24.04` seems to fix the issue.
  • Loading branch information
bartlomieju authored Oct 17, 2024
1 parent e6e58db commit 53df3ea
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ jobs:
# The extracted configurations are transformed into a matrix structure, which includes the label (job name),
# operating system (OS), and specific job type.
compute-jobs:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
outputs:
# If we're not running in the denoland repo, use the 'nop' matrix that runs a single, no-op job
matrix: |
${{
steps.read-jobs-fast.outputs.matrix
|| steps.read-jobs-pr.outputs.matrix
|| steps.read-jobs-tag.outputs.matrix
|| '{ "label": "linux", "os": "ubuntu-latest", "job": "nop" }'
|| '{ "label": "linux", "os": "ubuntu-24.04", "job": "nop" }'
}}
is_tag: ${{ github.repository == 'denoland/deno_core' && startsWith(github.ref, 'refs/tags/') }}
is_main: ${{ github.repository == 'denoland/deno_core' && github.ref == 'refs/heads/main' }}
Expand All @@ -45,7 +45,7 @@ jobs:
query: "{ matrix: [. | to_entries[] | . as $entry | .value.jobs[] | { label: $entry.key, os: $entry.value.os, job: . }] }"
config: |-
linux:
os: ubuntu-latest
os: ubuntu-24.04
jobs: [lint, test]
- name: Read job configuration (PR/main)
uses: cloudposse/github-action-yaml-config-query@main
Expand All @@ -55,7 +55,7 @@ jobs:
query: "{ matrix: [. | to_entries[] | . as $entry | .value.jobs[] | { label: $entry.key, os: $entry.value.os, job: . }] }"
config: |-
linux:
os: ubuntu-latest
os: ubuntu-24.04
jobs: [coverage, lint, lint-deps, test, test-miri, test-ops, test-publish]
linux-xl:
os: ubuntu-22.04-xl
Expand All @@ -77,7 +77,7 @@ jobs:
query: "{ matrix: [. | to_entries[] | . as $entry | .value.jobs[] | { label: $entry.key, os: $entry.value.os, job: . }] }"
config: |-
linux:
os: ubuntu-latest
os: ubuntu-24.04
jobs: [publish]
# This job is responsible for coordinating the execution of individual jobs defined in `ci-job.yml` based on the matrix generated
Expand All @@ -101,7 +101,7 @@ jobs:
# completed successfully. This allows us to have a single "build success" step for the repository.
success:
needs: [top, compute-jobs]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: ${{ always() }}
steps:
- name: Print variables
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
rust:
name: release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30

steps:
Expand Down

0 comments on commit 53df3ea

Please sign in to comment.