fix(watcher): watcher doesn't exit when module resolution fails #8521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the file watcher continue to work even if module resolution fails at the initial attempt, allowing us to execute `run` or `bundle` subcommand when a script has invalid syntax. In such cases, the watcher observes a single file that is specified as an command line argument. Fixes denoland#7848
bartlomieju
reviewed
Nov 27, 2020
bartlomieju
approved these changes
Nov 28, 2020
There was a problem hiding this comment.
I've tested this PR locally, works great, very good fix @magurotuna, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the file watcher continue to work even if module
resolution fails at the initial attempt, allowing us to execute
runor
bundlesubcommand when a script has invalid syntax. In suchcases, the watcher observes a single file that is specified as an
command line argument.
Fixes #7848