fix test_raw_tty hang #8520
Merged
fix test_raw_tty hang #8520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OSX I can reproduce the hang reliably by running: while true; do cargo test -p deno tty -- --nocapture; done Sometimes you have to wait a bit, but it shows up eventually. I never see the hang when running while true; do cargo test -p deno test_raw_tty -- --nocapture; done Therefore I think its related to fork / test runner.
Closed
bartlomieju
approved these changes
Nov 27, 2020
|
@bartlomieju I think so, I will investigate. -> #8525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX and linux I can reproduce the hang reliably by running:
Sometimes you have to wait a bit, but it shows up eventually.
I never see the hang when running
Therefore I think its related to fork / test runner.
Edit: working now.
Closes #4262