Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clippy future cleanups #8514

Merged
merged 2 commits into from
Nov 27, 2020
Merged

chore: clippy future cleanups #8514

merged 2 commits into from
Nov 27, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Nov 27, 2020

clippy nightly has some new rules that have identified a few cleanups

@kitsonk kitsonk requested a review from bartlomieju November 27, 2020 06:13
bartlomieju
bartlomieju approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ry
ry approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I love that clippy consistently results in less code.

@kitsonk kitsonk merged commit e2858d0 into denoland:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitsonk @ry @bartlomieju