fix(cli/ops/net): add write permissions for unixpackets datagrams & unix socket #8511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wperron
changed the title
bartlomieju
reviewed
Nov 26, 2020
There was a problem hiding this comment.
@wperron the fix looks good. Please add a test case in cli/tests/unit/net_test.ts that verifies PermissionDenied error is thrown
wperron
force-pushed
the
fix/datagram-perms
branch
from
1292e61 to
473bf99
Compare
wperron
force-pushed
the
fix/datagram-perms
branch
from
473bf99 to
4754d51
Compare
ry
approved these changes
Nov 27, 2020
bartlomieju
reviewed
Nov 27, 2020
Comment on lines
+71
to
+83
| try { | ||
| const filePath = Deno.makeTempFileSync(); | ||
| const socket = Deno.listen({ | ||
| path: filePath, | ||
| transport: "unix", | ||
| }); | ||
| assert(socket.addr.transport === "unix"); | ||
| assertEquals(socket.addr.path, filePath); | ||
| socket.close(); | ||
| } catch (e) { | ||
| assert(!!e); | ||
| assert(e instanceof Deno.errors.PermissionDenied); | ||
| } |
There was a problem hiding this comment.
@wperron this is a bit brittle - if function doesn't throw test will pass anyway. There's a helper assert called assertThrows that could be used for this purpose.
There was a problem hiding this comment.
I'll open a new PR for that
wperron
added a commit
to wperron/deno
that referenced
this pull request
Nov 27, 2020
Fixes a brittle test that was identified in denoland#8511 after it was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7781