fix: panic in worker when closing at top level #8510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
bartlomieju
changed the title
ry
reviewed
Nov 26, 2020
| let prefix = "file://"; | ||
| if (Deno.build.os == "windows") { | ||
| prefix += "/"; | ||
| } |
There was a problem hiding this comment.
Aside: I wish had something like Deno.makeTempFile().toUrl()
ry
reviewed
Nov 26, 2020
| // evaluation was complete. This can happen in Web Worker when `self.close()` | ||
| // is called at top level. | ||
| let result = maybe_result.unwrap_or(Ok(())); | ||
| return Poll::Ready(result); |
There was a problem hiding this comment.
It would be really great to have a standalone test in core for this...
bartlomieju
force-pushed
the
panic_in_worker
branch
from
bff8f67 to
08a5e95
Compare
ry
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panic occurring in worker when
self.close()is calledat the top level, ie. worker shuts down while
module evaluation promise hasn't yet resolved.
Closes #7620
Closes #5334
Supersedes #8395