Skip to content

fix(std/encoding/csv) Correct readme formatting due to dprint issues #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2020
Merged

fix(std/encoding/csv) Correct readme formatting due to dprint issues #8503

merged 2 commits into from
Nov 26, 2020

Conversation

jsejcksn
Copy link
Contributor

@jsejcksn jsejcksn commented Nov 26, 2020 •
edited
Loading

Ref: #8408 (comment):

assuming 05e0760 is the proper result

@dsherret @bartlomieju It is not the proper result.

It breaks the code blocks (includes literal triple ticks in the code bocks), and also improperly nests some code blocks in unrelated list items.

Visually compare the intended version (703aed6) to the auto-formatted version (05e0760).

@jsejcksn
Copy link
Contributor Author

@bartlomieju PTAL

bartlomieju
bartlomieju approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick fix @jsejcksn

@bartlomieju bartlomieju merged commit 01e8711 into denoland:master Nov 26, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@jsejcksn
fix(std/encoding/csv): Correct readme formatting due to dprint issues (…
a5edaed 
…denoland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@jsejcksn
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
f2eb135 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@jsejcksn @caspervonb
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
cd8040d 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@jsejcksn @caspervonb
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
1d8cb31 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@jsejcksn @caspervonb
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
0e02ef7 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@jsejcksn @caspervonb
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
c7288f3 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@jsejcksn @caspervonb
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
12da92d 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@jsejcksn @denobot
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
7120fc4 
…noland/deno#8503)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@jsejcksn @denobot
fix(encoding/csv): Correct readme formatting due to dprint issues (de…
d336162 
…noland/deno#8503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsejcksn @bartlomieju