Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make output of deno info --json deterministic #8483

Merged
merged 4 commits into from
Nov 27, 2020

Conversation

wperron
Copy link
Contributor

@wperron wperron commented Nov 24, 2020

changed the HashSet used to build the ModuleInfoMap for a BTreeSet to keep the items sorted

Fixes #8458

@wperron wperron force-pushed the fix/info-json-order branch from afefced to 11a3ccc Compare November 25, 2020 18:13
@wperron wperron marked this pull request as ready for review November 25, 2020 18:13
@wperron wperron changed the title WIP: fix module info map item order fix module info map item order Nov 25, 2020
@wperron wperron force-pushed the fix/info-json-order branch from bd9072e to a3ecc61 Compare November 26, 2020 16:13
@bartlomieju bartlomieju changed the title fix module info map item order fix(cli): make output of deno info --json deterministic Nov 26, 2020
@kitsonk kitsonk self-requested a review November 27, 2020 11:38
@wperron wperron force-pushed the fix/info-json-order branch 3 times, most recently from bbb5005 to 406edf4 Compare November 27, 2020 15:16
changed the HashSet used to build the output graph for a BTreeSet to keep the items sorted

Fixes denoland#8458
@wperron wperron force-pushed the fix/info-json-order branch from 406edf4 to bff5339 Compare November 27, 2020 18:28
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 57f1635 into denoland:master Nov 27, 2020
@wperron wperron deleted the fix/info-json-order branch January 17, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno info --json deps order is not deterministic
3 participants