Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(cli/tsc_config): Make isolatedModules non-configurable #8482

Merged

Conversation

nayeemrmn
Copy link
Collaborator

No description provided.

@bartlomieju bartlomieju added this to the 1.6.0 milestone Nov 24, 2020
@bartlomieju bartlomieju requested review from bartlomieju, kitsonk, lucacasonato and ry and removed request for ry, lucacasonato and bartlomieju November 24, 2020 21:42
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bartlomieju
Copy link
Member

Sorry, for pinging everyone, glitch in UI 😞

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit adbbd85 into denoland:master Nov 25, 2020
@nayeemrmn nayeemrmn deleted the isolated-modules-non-configurable branch November 29, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants