Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/websocket): set User-Agent header #8470

Merged
merged 2 commits into from
Nov 26, 2020
Merged

fix(cli/websocket): set User-Agent header #8470

merged 2 commits into from
Nov 26, 2020

Conversation

crowlKats
Copy link
Member

No description provided.

@bartlomieju
Copy link
Member

@crowlKats great, could you add some assert regarding user agent in a test?

bartlomieju
bartlomieju approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju changed the title fix(cli/websocket): set useragent fix(cli/websocket): set User-Agent header Nov 26, 2020
@bartlomieju bartlomieju merged commit a837fb9 into denoland:master Nov 26, 2020
@crowlKats crowlKats deleted the websocket_useragent branch November 26, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crowlKats @bartlomieju