Skip to content

fix(cli): allow setting of importsNotUsedAsValues in Deno.compile() #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(cli): allow setting of importsNotUsedAsValues in Deno.compile() #8306

merged 1 commit into from
Nov 9, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Nov 9, 2020

Fixes #6663

@kitsonk kitsonk requested a review from bartlomieju November 9, 2020 07:43
bartlomieju
bartlomieju approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit b402b75 into denoland:master Nov 9, 2020
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
@kitsonk @jannes
fix(cli): allow setting of importsNotUsedAsValues in Deno.compile() (d…
0f2b403 
…enoland#8306)

Fixes denoland#6663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.bundle() should accept the compiler flag importsNotUsedAsValues
2 participants
@kitsonk @bartlomieju