fix(cache): avoid local vendor path collisions - #36355
Open
nathanwhit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitized URL components in local vendor directories retained only a short digest suffix, so distinct URL components could resolve to the same file or directory.
This uses the full SHA-256 digest while shortening the readable prefix to keep hashed path components bounded. Existing hashed layouts are regenerated through the normal global-to-local cache population path.
Tests cover a previously colliding URL pair, the maximum ordinary hashed component length, and regeneration from an existing short-hash layout.
Tests
./tools/format.js libs/cache_dir/local.rs libs/cache_dir/tests/integration_test.rscargo test -p deno_cache_dir -- --nocapturecargo build -p deno --bin deno