feat(unstable): refactor and expose http upgrades #30784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
commented
Sep 19, 2025
ext/fetch/26_fetch.js
Outdated
| if (nullBodyStatus(response.status)) { | ||
| if (req.client?.allowUpgrades && response.status === 101) { | ||
| response.body = new InnerBody( | ||
| createResponseBodyStream(resp.responseRid, terminator), |
There was a problem hiding this comment.
need to come up with a way to avoid creating a readable stream here
devsnek
force-pushed
the
better-upgrades-2
branch
2 times, most recently
from
0b3ffb6 to
b51cbe8
Compare
devsnek
force-pushed
the
better-upgrades-2
branch
from
b51cbe8 to
f20fff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose
upgradeHttpRawand maintain upgraded requests through fetch+Deno.serve.