fix(compile): panic when compiled with --no-terminal flag #28823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
pushed a commit
to denoland/deno_core
that referenced
this pull request
Apr 11, 2025
This works towards fixing [#27730](denoland/deno#27730) and [#21091](denoland/deno#21091). An error is not handled when calling `op_is_terminal`. Ironically, this causes the application to panic when bootstrapping if there is no terminal in windows. This PR does not fully fix the issue yet, as there is a similar problem in deno's code base, see this [pull request](denoland/deno#28823).
|
Can some one please review this one? 🙏 Not sure if/who I should mention to get more eyes on it, or just have patience... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works towards fixing #27730 and #21091.
When compiled with the
--no-terminalflag under windows there are some issues related to stdin, stdout and stderr.This pull request fixes the panic when during bootstrap the terminal type is requested.
Previously it would return the error if the terminal was not valid, instead it now returns UNKNOWN.
The dummy stdin that is than provided instantly pushes null for some reason.
However this tries to do a
debugLogwhich is not possible yet, as we are still initiating.I don't see the use for this push, so I removed the line.
If it is needed for something please let me know.
This PR does not fully fix the issue yet, as there is a similar problem in deno_core's
isTerminalop, see this pull request.