Skip to content

fix(cli/test/bench/lsp): report errors as usual when only option is used #28783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cre3per
Copy link
Contributor

@Cre3per Cre3per commented Apr 7, 2025

only show 'Test failed because the "only" option was used' when all tests pass

part of #28648
does not change deno's exit code

draft, help needed:

  • lsp tests are flaky. res queue is empty occasionally
    • reproduce: repeatedly run cargo test lsp_testing
    • assumed cause: cli/lsp/testing/execution.rs, TestRunner::exec() runs a recv() loop which stops when there are no more events. The events are sent by run_tests_for_worker_inner(), which is spawned asynchronously. The recv() loop might start when no events have been written yet, and stops immediately.
    • how to help: confirm the assumption, then fix it or open a new issue. if assumption is wrong, find cause of flaky tests
  • tests should use local std library, not jsr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant