feat(lsp): jupyter cell continuity using classic scripts #28769
Merged
+1,260
−396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
Apr 6, 2025
dsherret
reviewed
Apr 8, 2025
dsherret
reviewed
Apr 8, 2025
nayeemrmn
requested review from
dsherret,
bartlomieju and
nathanwhit
and removed request for
bartlomieju
nayeemrmn
commented
Apr 10, 2025
dsherret
reviewed
Apr 11, 2025
nayeemrmn
commented
Apr 12, 2025
|
@dsherret PTAL |
dsherret
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21709.
Fixes denoland/vscode_deno#932.
VSCode's node/TS server also relies on classic scripts to share variables between cells. But in their case if you use a static import in some cell it will trigger module detection and the variables in that cell will not be shared. Our implementation will bypass this!