fix: only strip local and debug symbols from macOS binary #28758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
pushed a commit
that referenced
this pull request
Apr 5, 2025
Fixes #28757. We need to retain the napi symbols in the binary. `strip` with no flags on macos strips all symbols out of the binary (including global symbols). Only strip out the local and debug symbols from the binary, retaining the global symbols (which include the napi ones)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28757.
We need to retain the napi symbols in the binary.
stripwith no flags on macos strips all symbols out of the binary (including global symbols).Only strip out the local and debug symbols from the binary, retaining the global symbols (which include the napi ones)