fix(compile): ensure atime/birthtime/mtime/ctime is set in vfs #28731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a globally static variable `METADATA` when use standalone. And returns `METADATA.build_time` when get `atime/birthtime/mtime/ctime` of VfsFile.
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tests/specs/compile/determinism/test.jsonc: Language not supported
- tests/specs/compile/include/data_files/non_existent.out: Language not supported
Comments suppressed due to low confidence (1)
tests/specs/compile/determinism/setup.ts:1
- Removal of the determinism test setup may reduce coverage for ensuring that directory names do not affect the compile output. Please verify that equivalent tests exist elsewhere to cover this behavior.
// Removed test setup used for verifying determinism in output
anandfresh
approved these changes
Apr 4, 2025
dsherret
added a commit
that referenced
this pull request
Apr 5, 2025
Co-authored-by: XYCode <xycode-xyc@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceeds #28580 (see #28580 (comment))
Closes #28563
Closes #28580