Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/os): explicitly enable sysinfoapi feature on winapi dependency #28568

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

adakite1
Copy link
Contributor

This pr explicitly enables the sysinfoapi feature flag on winapi in deno_os, so that deno_os and other deno crates that rely on it can be built independently outside of the workspace on Windows. (Closes #28557)

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) March 21, 2025 02:33
@dsherret dsherret merged commit 7afdff6 into denoland:main Mar 21, 2025
18 checks passed
ry pushed a commit that referenced this pull request Mar 21, 2025
…dency (#28568)

This pr explicitly enables the `sysinfoapi` feature flag on `winapi` in
`deno_os`, so that `deno_os` and other deno crates that rely on it can
be built independently outside of the workspace on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno_os: sysinfoapi feature flag on winapi dependency not enabled, can't build the crate
3 participants