fix(ext/node): add util.getCallSites #28546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
force-pushed
the
fix-ext-node-add-get-call-sites
branch
from
aea7df5 to
23060da
Compare
kt3k
force-pushed
the
fix-ext-node-add-get-call-sites
branch
from
23060da to
573f601
Compare
petamoriken
reviewed
Mar 19, 2025
ext/node/polyfills/util.ts
Outdated
Comment on lines
370
to
371
| // deno-lint-ignore prefer-primordials | ||
| Error.captureStackTrace(target, getCallSites); |
There was a problem hiding this comment.
ErrorCaptureStackTrace should be in primordials.
deno/ext/console/01_console.js
Line 64 in 3849ace
marvinhagemeister
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
LGTM, would switch to primordials like @petamoriken suggested. Otherwise looks good!
ry
pushed a commit
that referenced
this pull request
Mar 21, 2025
This PR adds [getCallSites](https://nodejs.org/api/util.html#utilgetcallsitesframecount-options) API to "node:util". This unblocks #28318. Currently the task is blocked by the unavailability of `util.getCallSites` because it's used in [`test/common/index.js`](https://github.com/denoland/node_test/blob/8846b5392f4ebd3d4e995b9bed61c23c0192d806/test/common/index.js#L31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds getCallSites API to "node:util".
This unblocks #28318. Currently the task is blocked by the unavailability of
util.getCallSitesbecause it's used intest/common/index.js