Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): unfurl sloppy imports in d.ts files and type imports #27793

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(publish): unfurl sloppy imports in d.ts files and type imports #27793

merged 1 commit into from
Jan 23, 2025

Conversation

lucacasonato
Copy link
Member

Fixes a bug discovered while trying to publish a package with .js + .d.ts with sloppy imports.

marvinhagemeister
marvinhagemeister approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato enabled auto-merge (squash) January 23, 2025 14:02
dsherret
dsherret approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@lucacasonato lucacasonato merged commit c38dbe5 into denoland:main Jan 23, 2025
17 checks passed
@lucacasonato lucacasonato deleted the fix_sloppy_rewrite_in_dts_publish branch January 23, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacasonato @marvinhagemeister @dsherret