fix(check): compiler options from workspace members #27785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
…ber-compiler-options
dsherret
commented
Jan 23, 2025
dsherret
commented
Jan 28, 2025
cli/util/collections.rs
Outdated
There was a problem hiding this comment.
@nayeemrmn I extracted out this common pattern to a helper collection. Maybe we should use it in more places in the future.
| @@ -146,7 +146,7 @@ fn check_error_in_dep_then_fix() { | |||
| let check_command = test_context.new_command().args_vec(["check", "main.ts"]); | |||
|
|
|||
| let output = check_command.run(); | |||
| output.assert_matches_text("Check [WILDCARD]main.ts\nerror: TS234[WILDCARD]"); | |||
| output.assert_matches_text("Check [WILDCARD]main.ts\nTS234[WILDCARD]"); | |||
There was a problem hiding this comment.
Errors don't all get dispalyed at once anymore--they get displayed to the screen after each group of roots gets type checked.
bartlomieju
pushed a commit
that referenced
this pull request
Jan 30, 2025
Co-authored-by: Nayeem Rahman <nayeemrmn99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach to #27009 that instead mostly just changes the
TypeCheckerstruct.Todo:
deno compilesupportdeno lintsupportcheckJsbased on the current referrer when walking rather than using a global valueasset:///node_types.d.tsCloses #24504