Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(child_process): map node --no-warnings flag to --quiet #26288

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(child_process): map node --no-warnings flag to --quiet #26288

merged 2 commits into from
Oct 16, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Oct 15, 2024 •
edited by bartlomieju
Loading

Closes #25899

littledivy
littledivy approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a test?

@bartlomieju bartlomieju mentioned this pull request Oct 16, 2024
Closed
@nathanwhit nathanwhit enabled auto-merge (squash) October 16, 2024 17:47
@nathanwhit nathanwhit merged commit f7dba52 into main Oct 16, 2024
17 checks passed
@nathanwhit nathanwhit deleted the no-warnings-flag branch October 16, 2024 18:25
@kensukesaito kensukesaito mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Wrangler, the CLI for Cloudflare Workers
3 participants
@nathanwhit @marvinhagemeister @littledivy