Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade deno_core #25042

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat: upgrade deno_core #25042

merged 1 commit into from
Aug 19, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Aug 14, 2024 •
edited
Loading

  • Update ffi turbocall to use revised fast call api
  • Remove v8_version function calls
  • *mut OwnedIsolate is no longer stored in OpCtx gotham store

littledivy
littledivy approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devsnek devsnek force-pushed the upgrade-core branch 3 times, most recently from ff938fc to c7b3e2f Compare August 19, 2024 13:46
bartlomieju
bartlomieju approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@devsnek devsnek enabled auto-merge (squash) August 19, 2024 13:55
@devsnek devsnek merged commit c0aa68a into main Aug 19, 2024
17 checks passed
@devsnek devsnek deleted the upgrade-core branch August 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devsnek @bartlomieju @littledivy